Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix symfony breakages #322

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix symfony breakages #322

merged 3 commits into from
Jan 9, 2025

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 7, 2025

  • update TraceableTracerProvider to support SDK 1.1.0+ (add updateConfigurator method).
  • update sdk dependency to 1.1 (which drops PHP 7.4+8.0 support)
  • update SystemClock refs from sdk to api
  • update psalm config
  • use stable versions

This makes the build green again.

Fixes: open-telemetry/opentelemetry-php#1461

* update TraceableTracerProvider to support SDK 1.1.0+ (add updateConfigurator method).
* update sdk dependency to 1.1 (which drops PHP 7.4+8.0 support)
* update SystemClock refs from sdk to api
* update psalm config
@brettmc brettmc requested a review from a team as a code owner January 7, 2025 04:01
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.66%. Comparing base (4e6037a) to head (ff48b92).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/OtelSdkBundle/Debug/TraceableTracerProvider.php 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #322      +/-   ##
============================================
+ Coverage     79.75%   81.66%   +1.90%     
- Complexity      249      936     +687     
============================================
  Files            32       83      +51     
  Lines           988     3883    +2895     
============================================
+ Hits            788     3171    +2383     
- Misses          200      712     +512     
Flag Coverage Δ
Instrumentation/CakePHP 20.00% <ø> (?)
Instrumentation/CodeIgniter 73.77% <ø> (?)
Instrumentation/Curl 90.66% <ø> (?)
Instrumentation/Guzzle 69.51% <ø> (?)
Instrumentation/HttpAsyncClient 81.25% <ø> (?)
Instrumentation/IO 70.68% <ø> (?)
Instrumentation/MongoDB 76.31% <ø> (?)
Instrumentation/OpenAIPHP 87.31% <ø> (?)
Instrumentation/PDO 89.95% <ø> (?)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 81.15% <ø> (?)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.89% <ø> (ø)
Instrumentation/Symfony 88.70% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (?)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/OtelSdkBundle/Debug/TraceableTracerProvider.php 83.33% <0.00%> (ø)

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6037a...ff48b92. Read the comment docs.

src/Symfony/composer.json Show resolved Hide resolved
@brettmc brettmc merged commit 6542b13 into open-telemetry:main Jan 9, 2025
94 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry-php-contrib] TraceableTracerProvider missing required implementation
2 participants